OSDN Git Service

hwmon: (acpi_power_meter) Fix compiler warning seen in some configurations
authorGuenter Roeck <linux@roeck-us.net>
Wed, 28 Mar 2012 16:03:26 +0000 (09:03 -0700)
committerGuenter Roeck <guenter.roeck@ericsson.com>
Mon, 9 Apr 2012 19:17:37 +0000 (12:17 -0700)
In some configurations, BUG() does not result in an endless loop but returns
to the caller. This results in the following compiler warning:

drivers/hwmon/acpi_power_meter.c: In function 'show_str':
drivers/hwmon/acpi_power_meter.c:380: warning: 'val' may be used uninitialized in this function

Fix the warning by setting val to an empty string after BUG().

Signed-off-by: Guenter Roeck <linux@roeck-us.net>
Reviewed-by: Robert Coulson <robert.coulson@ericsson.com>
drivers/hwmon/acpi_power_meter.c

index 145f135..9140236 100644 (file)
@@ -391,6 +391,7 @@ static ssize_t show_str(struct device *dev,
                break;
        default:
                BUG();
+               val = "";
        }
 
        return sprintf(buf, "%s\n", val);