Don't clear surface if only src rect has changed.

We clear surface as needed depending on Display rect
changes. This should be enough to handle all cases.

Jira: None.
Test: No new regressions seen on Android.
Signed-off-by: Kalyan Kondapally <kalyan.kondapally@intel.com>

diff --git a/common/core/hwclayer.cpp b/common/core/hwclayer.cpp
index cdb90b4..6dab385 100644 (file)
--- a/common/core/hwclayer.cpp
+++ b/common/core/hwclayer.cpp
@@ -64,8 +64,6 @@ void HwcLayer::SetSourceCrop(const HwcRect<float>& source_crop) {
       (source_crop.top != source_crop_.top) ||
       (source_crop.bottom != source_crop_.bottom)) {
     layer_cache_ |= kSourceRectChanged;
-    UpdateRenderingDamage(HwcRect<int>(source_crop), HwcRect<int>(source_crop_),
-                          false);
     source_crop_ = source_crop;
     source_crop_width_ =
         static_cast<int>(ceilf(source_crop.right - source_crop.left));

diff --git a/common/display/displayplanestate.cpp b/common/display/displayplanestate.cpp
index 264f5ba..bd5ec98 100644 (file)
--- a/common/display/displayplanestate.cpp
+++ b/common/display/displayplanestate.cpp
@@ -249,8 +249,7 @@ void DisplayPlaneState::RefreshLayerRects(
     const HwcRect<float> &source_crop = layer.GetSourceCrop();
     CalculateRect(df, target_display_frame);
     CalculateSourceRect(source_crop, target_source_crop);
-    if (!layer.IsCursorLayer() &&
-        (layer.HasDimensionsChanged() || layer.HasSourceRectChanged())) {
+    if (!layer.IsCursorLayer() && (layer.HasDimensionsChanged())) {
       only_cursor_layer = false;
     }
 

diff --git a/common/display/displayqueue.cpp b/common/display/displayqueue.cpp
index e97291d..cf4a64b 100644 (file)
--- a/common/display/displayqueue.cpp
+++ b/common/display/displayqueue.cpp
@@ -311,7 +311,7 @@ void DisplayQueue::GetCachedLayers(const std::vector<OverlayLayer>& layers,
         for (size_t i = 0; i < layers_size; i++) {
           const size_t& source_index = source_layers.at(i);
           const OverlayLayer& layer = layers.at(source_index);
-          if (layer.HasDimensionsChanged() || layer.HasSourceRectChanged()) {
+          if (layer.HasDimensionsChanged()) {
             update_rect = true;
             break;
           }