OSDN Git Service

scsi: mpt3sas: Add missing breaks in switch statements
authorGustavo A. R. Silva <gustavo@embeddedor.com>
Fri, 15 Feb 2019 21:54:14 +0000 (15:54 -0600)
committerMartin K. Petersen <martin.petersen@oracle.com>
Wed, 27 Feb 2019 14:36:54 +0000 (09:36 -0500)
Fix the following warnings by adding the proper missing breaks:

drivers/scsi/mpt3sas/mpt3sas_base.c: In function  _base_display_OEMs_branding :
drivers/scsi/mpt3sas/mpt3sas_base.c:3548:4: warning: this statement may fall through [-Wimplicit-fallthrough=]
    switch (ioc->pdev->subsystem_device) {
    ^~~~~~
drivers/scsi/mpt3sas/mpt3sas_base.c:3566:3: note: here
   case MPI2_MFGPAGE_DEVID_SAS2308_2:
   ^~~~
drivers/scsi/mpt3sas/mpt3sas_base.c:3567:4: warning: this statement may fall through [-Wimplicit-fallthrough=]
    switch (ioc->pdev->subsystem_device) {
    ^~~~~~
drivers/scsi/mpt3sas/mpt3sas_base.c:3601:3: note: here
   case MPI25_MFGPAGE_DEVID_SAS3008:
   ^~~~
drivers/scsi/mpt3sas/mpt3sas_base.c:3735:4: warning: this statement may fall through [-Wimplicit-fallthrough=]
    switch (ioc->pdev->subsystem_device) {
    ^~~~~~
drivers/scsi/mpt3sas/mpt3sas_base.c:3745:3: note: here
   case MPI2_MFGPAGE_DEVID_SAS2308_2:
   ^~~~
drivers/scsi/mpt3sas/mpt3sas_base.c:3746:4: warning: this statement may fall through [-Wimplicit-fallthrough=]
    switch (ioc->pdev->subsystem_device) {
    ^~~~~~
drivers/scsi/mpt3sas/mpt3sas_base.c:3768:3: note: here
   default:
   ^~~~~~~

Warning level 3 was used: -Wimplicit-fallthrough=3

This patch is part of the ongoing efforts to enable
-Wimplicit-fallthrough.

Signed-off-by: Gustavo A. R. Silva <gustavo@embeddedor.com>
Signed-off-by: Martin K. Petersen <martin.petersen@oracle.com>
drivers/scsi/mpt3sas/mpt3sas_base.c

index 0a6cb8f..e577744 100644 (file)
@@ -3563,6 +3563,7 @@ _base_display_OEMs_branding(struct MPT3SAS_ADAPTER *ioc)
                                         ioc->pdev->subsystem_device);
                                break;
                        }
+                       break;
                case MPI2_MFGPAGE_DEVID_SAS2308_2:
                        switch (ioc->pdev->subsystem_device) {
                        case MPT2SAS_INTEL_RS25GB008_SSDID:
@@ -3598,6 +3599,7 @@ _base_display_OEMs_branding(struct MPT3SAS_ADAPTER *ioc)
                                         ioc->pdev->subsystem_device);
                                break;
                        }
+                       break;
                case MPI25_MFGPAGE_DEVID_SAS3008:
                        switch (ioc->pdev->subsystem_device) {
                        case MPT3SAS_INTEL_RMS3JC080_SSDID:
@@ -3742,6 +3744,7 @@ _base_display_OEMs_branding(struct MPT3SAS_ADAPTER *ioc)
                                         ioc->pdev->subsystem_device);
                                break;
                        }
+                       break;
                case MPI2_MFGPAGE_DEVID_SAS2308_2:
                        switch (ioc->pdev->subsystem_device) {
                        case MPT2SAS_HP_2_4_INTERNAL_SSDID:
@@ -3765,6 +3768,7 @@ _base_display_OEMs_branding(struct MPT3SAS_ADAPTER *ioc)
                                         ioc->pdev->subsystem_device);
                                break;
                        }
+                       break;
                default:
                        ioc_info(ioc, "HP SAS HBA: Subsystem ID: 0x%X\n",
                                 ioc->pdev->subsystem_device);