OSDN Git Service

rtc: bq4802: add error handling for devm_ioremap
authorZhouyang Jia <jiazhouyang09@gmail.com>
Tue, 12 Jun 2018 04:40:03 +0000 (12:40 +0800)
committerAlexandre Belloni <alexandre.belloni@bootlin.com>
Wed, 11 Jul 2018 18:41:01 +0000 (20:41 +0200)
When devm_ioremap fails, the lack of error-handling code may
cause unexpected results.

This patch adds error-handling code after calling devm_ioremap.

Signed-off-by: Zhouyang Jia <jiazhouyang09@gmail.com>
Signed-off-by: Alexandre Belloni <alexandre.belloni@bootlin.com>
drivers/rtc/rtc-bq4802.c

index d768f67..113493b 100644 (file)
@@ -162,6 +162,10 @@ static int bq4802_probe(struct platform_device *pdev)
        } else if (p->r->flags & IORESOURCE_MEM) {
                p->regs = devm_ioremap(&pdev->dev, p->r->start,
                                        resource_size(p->r));
+               if (!p->regs){
+                       err = -ENOMEM;
+                       goto out;
+               }
                p->read = bq4802_read_mem;
                p->write = bq4802_write_mem;
        } else {