OSDN Git Service

net: dsa: Pass pcs_poll flag from driver to PHYLINK
authorVladimir Oltean <vladimir.oltean@nxp.com>
Mon, 6 Jan 2020 01:34:12 +0000 (03:34 +0200)
committerDavid S. Miller <davem@davemloft.net>
Mon, 6 Jan 2020 07:22:32 +0000 (23:22 -0800)
The DSA drivers that implement .phylink_mac_link_state should normally
register an interrupt for the PCS, from which they should call
phylink_mac_change(). However not all switches implement this, and those
who don't should set this flag in dsa_switch in the .setup callback, so
that PHYLINK will poll for a few ms until the in-band AN link timer
expires and the PCS state settles.

Signed-off-by: Vladimir Oltean <vladimir.oltean@nxp.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
include/net/dsa.h
net/dsa/port.c

index 23b1c58..0c39fed 100644 (file)
@@ -279,6 +279,11 @@ struct dsa_switch {
         */
        bool                    vlan_filtering;
 
+       /* MAC PCS does not provide link state change interrupt, and requires
+        * polling. Flag passed on to PHYLINK.
+        */
+       bool                    pcs_poll;
+
        size_t num_ports;
 };
 
index ffb5601..774facb 100644 (file)
@@ -599,6 +599,7 @@ static int dsa_port_phylink_register(struct dsa_port *dp)
 
        dp->pl_config.dev = ds->dev;
        dp->pl_config.type = PHYLINK_DEV;
+       dp->pl_config.pcs_poll = ds->pcs_poll;
 
        dp->pl = phylink_create(&dp->pl_config, of_fwnode_handle(port_dn),
                                mode, &dsa_port_phylink_mac_ops);