OSDN Git Service

drm/amdgpu: Potential uninitialized variable in amdgpu_vm_update_directories()
authorDan Carpenter <dan.carpenter@oracle.com>
Sat, 30 Sep 2017 08:14:13 +0000 (11:14 +0300)
committerAlex Deucher <alexander.deucher@amd.com>
Wed, 8 Nov 2017 22:55:04 +0000 (17:55 -0500)
After commit ea09729c9302 ("drm/amdgpu: rework page directory filling
v2") then it becomes a lot harder to verify that "r" is initialized.  My
static checker complains and so I've reviewed the code.  It does look
like it might be buggy... Anyway, it doesn't hurt to set "r" to zero
at the start.

Reviewed-by: Christian König <christian.koenig@amd.com>
Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
Signed-off-by: Alex Deucher <alexander.deucher@amd.com>
Cc: stable@vger.kernel.org
drivers/gpu/drm/amd/amdgpu/amdgpu_vm.c

index 010d141..c8c26f2 100644 (file)
@@ -1244,7 +1244,7 @@ static void amdgpu_vm_invalidate_level(struct amdgpu_vm *vm,
 int amdgpu_vm_update_directories(struct amdgpu_device *adev,
                                 struct amdgpu_vm *vm)
 {
-       int r;
+       int r = 0;
 
        spin_lock(&vm->status_lock);
        while (!list_empty(&vm->relocated)) {