OSDN Git Service

drm/msm/dpu: rearrange QoS setting code
authorDmitry Baryshkov <dmitry.baryshkov@linaro.org>
Thu, 18 May 2023 22:22:33 +0000 (01:22 +0300)
committerDmitry Baryshkov <dmitry.baryshkov@linaro.org>
Sun, 4 Jun 2023 01:44:18 +0000 (04:44 +0300)
Slightly rearrainge code in dpu_plane_sspp_update_pipe() to group
QoS/LUT related functions.

Reviewed-by: Jeykumar Sankaran <quic_jeykumar@quicinc.com>
Signed-off-by: Dmitry Baryshkov <dmitry.baryshkov@linaro.org>
Patchwork: https://patchwork.freedesktop.org/patch/537906/
Link: https://lore.kernel.org/r/20230518222238.3815293-5-dmitry.baryshkov@linaro.org
Signed-off-by: Dmitry Baryshkov <dmitry.baryshkov@linaro.org>
drivers/gpu/drm/msm/disp/dpu1/dpu_plane.c

index b8ed724..586f089 100644 (file)
@@ -1079,10 +1079,10 @@ static void dpu_plane_sspp_update_pipe(struct drm_plane *plane,
                pipe->sspp->ops.setup_sourceaddress(pipe, layout);
        }
 
-       _dpu_plane_set_qos_ctrl(plane, pipe, false, DPU_PLANE_QOS_PANIC_CTRL);
-
        /* override for color fill */
        if (pdpu->color_fill & DPU_PLANE_COLOR_FILL_FLAG) {
+               _dpu_plane_set_qos_ctrl(plane, pipe, false, DPU_PLANE_QOS_PANIC_CTRL);
+
                /* skip remaining processing on color fill */
                return;
        }
@@ -1125,12 +1125,14 @@ static void dpu_plane_sspp_update_pipe(struct drm_plane *plane,
 
        _dpu_plane_set_qos_lut(plane, pipe, fmt, pipe_cfg);
        _dpu_plane_set_danger_lut(plane, pipe, fmt);
+       _dpu_plane_set_qos_ctrl(plane, pipe,
+                               pipe->sspp->idx != SSPP_CURSOR0 &&
+                               pipe->sspp->idx != SSPP_CURSOR1,
+                               DPU_PLANE_QOS_PANIC_CTRL);
 
        if (pipe->sspp->idx != SSPP_CURSOR0 &&
-           pipe->sspp->idx != SSPP_CURSOR1) {
-               _dpu_plane_set_qos_ctrl(plane, pipe, true, DPU_PLANE_QOS_PANIC_CTRL);
+           pipe->sspp->idx != SSPP_CURSOR1)
                _dpu_plane_set_ot_limit(plane, pipe, pipe_cfg, frame_rate);
-       }
 
        if (pstate->needs_qos_remap)
                _dpu_plane_set_qos_remap(plane, pipe);