OSDN Git Service

staging: rtl8821ae: a couple macro expansion bugs
authorDan Carpenter <dan.carpenter@oracle.com>
Tue, 28 Jan 2014 14:00:52 +0000 (17:00 +0300)
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Fri, 7 Feb 2014 18:30:39 +0000 (10:30 -0800)
These macros need parentheses, otherwise it causes a macro expansion bug
when they are used like this:

ch->flags &= ~IEEE80211_CHAN_NO_IBSS;

This was found using Smatch:
drivers/staging/rtl8821ae/regd.c:200 _rtl_reg_apply_beaconing_flags()
warn: the 'IEEE80211_CHAN_NO_IBSS' macro might need parens

Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
drivers/staging/rtl8821ae/regd.h

index abc60ab..dceb3f1 100644 (file)
@@ -30,8 +30,8 @@
 #ifndef __RTL_REGD_H__
 #define __RTL_REGD_H__
 
-#define IEEE80211_CHAN_NO_IBSS         1<<2
-#define IEEE80211_CHAN_PASSIVE_SCAN    1<<1
+#define IEEE80211_CHAN_NO_IBSS         (1 << 2)
+#define IEEE80211_CHAN_PASSIVE_SCAN    (1 << 1)
 #define WIPHY_FLAG_CUSTOM_REGULATORY   BIT(0)
 #define WIPHY_FLAG_STRICT_REGULATORY   BIT(1)
 #define WIPHY_FLAG_DISABLE_BEACON_HINTS        BIT(2)