OSDN Git Service

staging: dgnc: delete all references to 'flipbuf'
authorGujulan Elango, Hari Prasath (H.) <hgujulan@visteon.com>
Fri, 29 May 2015 07:17:37 +0000 (07:17 +0000)
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Sun, 31 May 2015 01:26:27 +0000 (10:26 +0900)
This patch deletes all references to 'flipbuf'.Memory is allocated and
freed but never used anywhere in the driver.Also deleted an ununsed
Macro defined in the header file.

Signed-off-by: Gujulan Elango Hari Prasath <hgujulan@visteon.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
drivers/staging/dgnc/dgnc_driver.c
drivers/staging/dgnc/dgnc_driver.h

index 805dc61..7546aff 100644 (file)
@@ -355,7 +355,6 @@ static void dgnc_cleanup_board(struct dgnc_board *brd)
                }
        }
 
-       kfree(brd->flipbuf);
 
        dgnc_Board[brd->boardnum] = NULL;
 
@@ -581,14 +580,6 @@ static int dgnc_found_board(struct pci_dev *pdev, int id)
        brd->msgbuf_head = NULL;
        spin_unlock_irqrestore(&dgnc_global_lock, flags);
 
-       /*
-        * allocate flip buffer for board.
-        *
-        * Okay to malloc with GFP_KERNEL, we are not at interrupt
-        * context, and there are no locks held.
-        */
-       brd->flipbuf = kzalloc(MYFLIPLEN, GFP_KERNEL);
-
        wake_up_interruptible(&brd->state_wait);
 
        return 0;
index f77fed5..3dee9f3 100644 (file)
@@ -212,8 +212,6 @@ struct dgnc_board {
 
        uint            TtyRefCnt;
 
-       char            *flipbuf;       /* Our flip buffer, alloced if board is found */
-
        u16             dpatype;        /* The board "type", as defined by DPA */
        u16             dpastatus;      /* The board "status", as defined by DPA */
 
@@ -288,7 +286,6 @@ struct un_t {
 #define CH_TX_FIFO_LWM  0x0800         /* TX Fifo is below Low Water   */
 #define CH_BREAK_SENDING 0x1000                /* Break is being sent          */
 #define CH_LOOPBACK 0x2000             /* Channel is in lookback mode  */
-#define CH_FLIPBUF_IN_USE 0x4000       /* Channel's flipbuf is in use  */
 #define CH_BAUD0       0x08000         /* Used for checking B0 transitions */
 #define CH_FORCED_STOP  0x20000                /* Output is forcibly stopped   */
 #define CH_FORCED_STOPI 0x40000                /* Input is forcibly stopped    */