simplify code by making special case more obvious

git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@76950 91177308-0d34-0410-b5e6-96231b3b80d8

diff --git a/lib/Target/PIC16/PIC16TargetAsmInfo.cpp b/lib/Target/PIC16/PIC16TargetAsmInfo.cpp
index c9ef45a..9adf63a 100644 (file)
--- a/lib/Target/PIC16/PIC16TargetAsmInfo.cpp
+++ b/lib/Target/PIC16/PIC16TargetAsmInfo.cpp
@@ -247,7 +247,6 @@ PIC16TargetAsmInfo::~PIC16TargetAsmInfo() {
 // which have a section name or address.
 const Section* 
 PIC16TargetAsmInfo::SectionForGlobal(const GlobalValue *GV) const {
-  const Section* S;
   // If GV has a sectin name or section address create that section now.
   if (GV->hasSection()) {
     std::string SectName = GV->getSection();
@@ -256,15 +255,12 @@ PIC16TargetAsmInfo::SectionForGlobal(const GlobalValue *GV) const {
     std::string AddrStr = "Address=";
     if (SectName.compare(0, AddrStr.length(), AddrStr) == 0) {
       std::string SectAddr = SectName.substr(AddrStr.length());
-      S = CreateSectionForGlobal(GV, SectAddr);
-    } else {
-      S = CreateSectionForGlobal(GV);
-    } 
-  } else {
-    // Use section depending on the 'type' of variable
-    S = SelectSectionForGlobal(GV);
+      return CreateSectionForGlobal(GV, SectAddr);
+    }
   }
-  return S;
+  
+  // Use section depending on the 'type' of variable
+  return SelectSectionForGlobal(GV);
 }
 
 // Create a new section for global variable. If Addr is given then create