OSDN Git Service

net: qed: Remove unneeded cast from memory allocation
authorWang Hai <wanghai38@huawei.com>
Wed, 22 Jul 2020 02:10:27 +0000 (10:10 +0800)
committerDavid S. Miller <davem@davemloft.net>
Thu, 23 Jul 2020 00:28:54 +0000 (17:28 -0700)
Remove casting the values returned by memory allocation function.

Coccinelle emits WARNING: casting value returned by memory allocation
unction to (struct roce_destroy_qp_req_output_params *) is useless.

This issue was detected by using the Coccinelle software.

Signed-off-by: Wang Hai <wanghai38@huawei.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
drivers/net/ethernet/qlogic/qed/qed_roce.c

index a1423ec..f16a157 100644 (file)
@@ -757,8 +757,7 @@ static int qed_roce_sp_destroy_qp_requester(struct qed_hwfn *p_hwfn,
        if (!qp->req_offloaded)
                return 0;
 
-       p_ramrod_res = (struct roce_destroy_qp_req_output_params *)
-                      dma_alloc_coherent(&p_hwfn->cdev->pdev->dev,
+       p_ramrod_res = dma_alloc_coherent(&p_hwfn->cdev->pdev->dev,
                                          sizeof(*p_ramrod_res),
                                          &ramrod_res_phys, GFP_KERNEL);
        if (!p_ramrod_res) {