OSDN Git Service

media: tc358743: remove an unneeded condition
authorDan Carpenter <dan.carpenter@oracle.com>
Thu, 28 Sep 2017 13:03:54 +0000 (15:03 +0200)
committerMauro Carvalho Chehab <mchehab@osg.samsung.com>
Fri, 27 Oct 2017 12:14:13 +0000 (14:14 +0200)
We can remove the check for if "state->cec_adap" is NULL.  The
cec_allocate_adapter() function never returns NULL and also we verified
that "state->cec_adap" is an error pointer.

Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
Signed-off-by: Hans Verkuil <hans.verkuil@cisco.com>
Signed-off-by: Mauro Carvalho Chehab <mchehab@osg.samsung.com>
drivers/media/i2c/tc358743.c

index 6c59a46..cd995e6 100644 (file)
@@ -2122,7 +2122,7 @@ static int tc358743_probe(struct i2c_client *client,
                state, dev_name(&client->dev),
                CEC_CAP_DEFAULTS | CEC_CAP_MONITOR_ALL, CEC_MAX_LOG_ADDRS);
        if (IS_ERR(state->cec_adap)) {
-               err = state->cec_adap ? PTR_ERR(state->cec_adap) : -ENOMEM;
+               err = PTR_ERR(state->cec_adap);
                goto err_hdl;
        }
        irq_mask |= MASK_CEC_RMSK | MASK_CEC_TMSK;