OSDN Git Service

staging/rtl8192u - check for skb alloc failure
authorValdis Kletnieks <Valdis.Kletnieks@vt.edu>
Mon, 8 Sep 2014 22:09:48 +0000 (18:09 -0400)
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Mon, 8 Sep 2014 22:22:52 +0000 (15:22 -0700)
It's possible for dev_alloc_skb() to fail. Propagate the error to the caller,
so it can clean up and drop the packet. The sender should end up retransmitting
the packet, hopefully at a time we're prepared to allocate skb's again.

Reported-By: Nicholas Krause <xerofoify@gmail.com>
Signed-Off-By: Valdis Kletnieks <valdis.kletnieks@vt.edu>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
drivers/staging/rtl8192u/ieee80211/ieee80211_rx.c

index 40da37f..73de9e9 100644 (file)
@@ -847,6 +847,8 @@ static u8 parse_subframe(struct sk_buff *skb,
 #else
                        /* Allocate new skb for releasing to upper layer */
                        sub_skb = dev_alloc_skb(nSubframe_Length + 12);
+                       if (!sub_skb)
+                               return 0;
                        skb_reserve(sub_skb, 12);
                        data_ptr = (u8 *)skb_put(sub_skb, nSubframe_Length);
                        memcpy(data_ptr, skb->data, nSubframe_Length);