OSDN Git Service

OMAPDSS: DISPC: Fix scaling constraints for OMAP4
authorArchit Taneja <archit@ti.com>
Mon, 30 Jan 2012 05:24:17 +0000 (10:54 +0530)
committerTomi Valkeinen <tomi.valkeinen@ti.com>
Tue, 21 Feb 2012 07:39:30 +0000 (09:39 +0200)
The calculation of required DISPC_FCLK for downscaling is done by multplying the
pixel clock with an integer factor. This isn't true for OMAP4 where the required
clock is calculated using the exact ratio of downscaling done.

Fix this calculation for OMAP4. Also, do a minor clean up of calc_fclk().

Signed-off-by: Archit Taneja <archit@ti.com>
Signed-off-by: Tomi Valkeinen <tomi.valkeinen@ti.com>
drivers/video/omap2/dss/dispc.c

index d8e044d..22023bb 100644 (file)
@@ -1694,6 +1694,7 @@ static unsigned long calc_fclk(enum omap_channel channel, u16 width,
                u16 height, u16 out_width, u16 out_height)
 {
        unsigned int hf, vf;
+       unsigned long pclk = dispc_mgr_pclk_rate(channel);
 
        /*
         * FIXME how to determine the 'A' factor
@@ -1716,13 +1717,16 @@ static unsigned long calc_fclk(enum omap_channel channel, u16 width,
 
        if (cpu_is_omap24xx()) {
                if (vf > 1 && hf > 1)
-                       return dispc_mgr_pclk_rate(channel) * 4;
+                       return pclk * 4;
                else
-                       return dispc_mgr_pclk_rate(channel) * 2;
+                       return pclk * 2;
        } else if (cpu_is_omap34xx()) {
-               return dispc_mgr_pclk_rate(channel) * vf * hf;
+               return pclk * vf * hf;
        } else {
-               return dispc_mgr_pclk_rate(channel) * hf;
+               if (hf > 1)
+                       return DIV_ROUND_UP(pclk, out_width) * width;
+               else
+                       return pclk;
        }
 }