OSDN Git Service

iio: adc: ad7124: Set IRQ type to falling
authorAlexandru Tachici <alexandru.tachici@analog.com>
Mon, 13 Jan 2020 10:26:53 +0000 (12:26 +0200)
committerJonathan Cameron <Jonathan.Cameron@huawei.com>
Sat, 18 Jan 2020 11:43:16 +0000 (11:43 +0000)
Ad7124 data-sheet specifies that the falling edge
of the DOUT line should be used for an interrupt.
The current irq flag (IRQF_TRIGGER_LOW) used will
cause unwanted behaviour. When enabling the interrupt
it will fire once because the DOUT line is already low.
This will make the driver to read an unfinished conversion
from the chip.

This patch sets the irq type to the one specified in
the data-sheet.

Signed-off-by: Alexandru Tachici <alexandru.tachici@analog.com>
Signed-off-by: Jonathan Cameron <Jonathan.Cameron@huawei.com>
drivers/iio/adc/ad7124.c

index 63df2e2..52f45b1 100644 (file)
@@ -225,7 +225,7 @@ static const struct ad_sigma_delta_info ad7124_sigma_delta_info = {
        .addr_shift = 0,
        .read_mask = BIT(6),
        .data_reg = AD7124_DATA,
-       .irq_flags = IRQF_TRIGGER_LOW,
+       .irq_flags = IRQF_TRIGGER_FALLING,
 };
 
 static int ad7124_set_channel_odr(struct ad7124_state *st,