OSDN Git Service

bcache: add code comments for state->pool in __btree_sort()
authorColy Li <colyli@suse.de>
Thu, 23 Jan 2020 17:01:36 +0000 (01:01 +0800)
committerJens Axboe <axboe@kernel.dk>
Thu, 23 Jan 2020 18:40:02 +0000 (11:40 -0700)
To explain the pages allocated from mempool state->pool can be
swapped in __btree_sort(), because state->pool is a page pool,
which allocates pages by alloc_pages() indeed.

Signed-off-by: Coly Li <colyli@suse.de>
Signed-off-by: Jens Axboe <axboe@kernel.dk>
drivers/md/bcache/bset.c

index cffcdc9..4385303 100644 (file)
@@ -1257,6 +1257,11 @@ static void __btree_sort(struct btree_keys *b, struct btree_iter *iter,
                 * Our temporary buffer is the same size as the btree node's
                 * buffer, we can just swap buffers instead of doing a big
                 * memcpy()
+                *
+                * Don't worry event 'out' is allocated from mempool, it can
+                * still be swapped here. Because state->pool is a page mempool
+                * creaated by by mempool_init_page_pool(), which allocates
+                * pages by alloc_pages() indeed.
                 */
 
                out->magic      = b->set->data->magic;