OSDN Git Service

drm/i915: Remove user-triggerable WARN from i915_gem_object_create
authorTvrtko Ursulin <tvrtko.ursulin@intel.com>
Thu, 30 Mar 2017 16:31:30 +0000 (17:31 +0100)
committerTvrtko Ursulin <tvrtko.ursulin@intel.com>
Tue, 4 Apr 2017 08:39:13 +0000 (09:39 +0100)
Since this can be triggered by simply attempting a huge object,
a WARN_ON is not appropriate.

Signed-off-by: Tvrtko Ursulin <tvrtko.ursulin@intel.com>
Reviewed-by: Chris Wilson <chris@chris-wilson.co.uk>
Link: http://patchwork.freedesktop.org/patch/msgid/20170330163130.24141-1-tvrtko.ursulin@linux.intel.com
drivers/gpu/drm/i915/i915_gem.c

index bbc6f1c..4ca88f2 100644 (file)
@@ -4195,7 +4195,7 @@ i915_gem_object_create(struct drm_i915_private *dev_priv, u64 size)
         * catch if we ever need to fix it. In the meantime, if you do spot
         * such a local variable, please consider fixing!
         */
-       if (WARN_ON(size >> PAGE_SHIFT > INT_MAX))
+       if (size >> PAGE_SHIFT > INT_MAX)
                return ERR_PTR(-E2BIG);
 
        if (overflows_type(size, obj->base.size))