OSDN Git Service

RDMA/qedr: clean up work queue on failure in qedr_alloc_resources()
authorDan Carpenter <dan.carpenter@oracle.com>
Tue, 25 Oct 2022 15:32:32 +0000 (18:32 +0300)
committerJason Gunthorpe <jgg@nvidia.com>
Fri, 28 Oct 2022 15:59:40 +0000 (12:59 -0300)
Add a check for if create_singlethread_workqueue() fails and also destroy
the work queue on failure paths.

Fixes: e411e0587e0d ("RDMA/qedr: Add iWARP connection management functions")
Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
Link: https://lore.kernel.org/r/Y1gBkDucQhhWj5YM@kili
Signed-off-by: Leon Romanovsky <leon@kernel.org>
Signed-off-by: Jason Gunthorpe <jgg@nvidia.com>
drivers/infiniband/hw/qedr/main.c

index 5152f10..ba0c3e4 100644 (file)
@@ -344,6 +344,10 @@ static int qedr_alloc_resources(struct qedr_dev *dev)
        if (IS_IWARP(dev)) {
                xa_init(&dev->qps);
                dev->iwarp_wq = create_singlethread_workqueue("qedr_iwarpq");
+               if (!dev->iwarp_wq) {
+                       rc = -ENOMEM;
+                       goto err1;
+               }
        }
 
        /* Allocate Status blocks for CNQ */
@@ -351,7 +355,7 @@ static int qedr_alloc_resources(struct qedr_dev *dev)
                                GFP_KERNEL);
        if (!dev->sb_array) {
                rc = -ENOMEM;
-               goto err1;
+               goto err_destroy_wq;
        }
 
        dev->cnq_array = kcalloc(dev->num_cnq,
@@ -402,6 +406,9 @@ err3:
        kfree(dev->cnq_array);
 err2:
        kfree(dev->sb_array);
+err_destroy_wq:
+       if (IS_IWARP(dev))
+               destroy_workqueue(dev->iwarp_wq);
 err1:
        kfree(dev->sgid_tbl);
        return rc;