OSDN Git Service

platform/x86: touchscreen_dmi: Remove the Glavey TM800A550L entry
authorHans de Goede <hdegoede@redhat.com>
Mon, 3 Jan 2022 11:27:00 +0000 (12:27 +0100)
committerHans de Goede <hdegoede@redhat.com>
Wed, 5 Jan 2022 10:31:18 +0000 (11:31 +0100)
The Glavey TM800A550L tablet is a tablet which ships with Android as
factory OS. As such it has the typical broken DSDT which x86 Android
tablets tend to have.

Specifically the touchscreen ACPI device node is missing the IRQ for
the touchscreen. So far users were expected to fix this with a DSDT
overlay, but support for the TM800A550L has been added to the new
x86-android-modules kernel-module and that will now automatically
instantiate a proper i2c-client with the IRQ set for the touchscreen,
including the necessary device-properties for the firmware loading.

This means that the touchscreen_dmi entry for the TM800A550L is
no longer necessary (and it no longer matches either since the
touchscreen is no longer enumerated through ACPI), remove it.

Signed-off-by: Hans de Goede <hdegoede@redhat.com>
Link: https://lore.kernel.org/r/20220103112700.111414-1-hdegoede@redhat.com
drivers/platform/x86/touchscreen_dmi.c

index 7acec7e..494f230 100644 (file)
@@ -361,18 +361,6 @@ static const struct ts_dmi_data gdix1001_01_upside_down_data = {
        .properties     = gdix1001_upside_down_props,
 };
 
-static const struct property_entry glavey_tm800a550l_props[] = {
-       PROPERTY_ENTRY_STRING("firmware-name", "gt912-glavey-tm800a550l.fw"),
-       PROPERTY_ENTRY_STRING("goodix,config-name", "gt912-glavey-tm800a550l.cfg"),
-       PROPERTY_ENTRY_U32("goodix,main-clk", 54),
-       { }
-};
-
-static const struct ts_dmi_data glavey_tm800a550l_data = {
-       .acpi_name      = "GDIX1001:00",
-       .properties     = glavey_tm800a550l_props,
-};
-
 static const struct property_entry gp_electronic_t701_props[] = {
        PROPERTY_ENTRY_U32("touchscreen-size-x", 960),
        PROPERTY_ENTRY_U32("touchscreen-size-y", 640),
@@ -1149,15 +1137,6 @@ const struct dmi_system_id touchscreen_dmi_table[] = {
                        DMI_MATCH(DMI_PRODUCT_NAME, "eSTAR BEAUTY HD Intel Quad core"),
                },
        },
-       {       /* Glavey TM800A550L */
-               .driver_data = (void *)&glavey_tm800a550l_data,
-               .matches = {
-                       DMI_MATCH(DMI_BOARD_VENDOR, "AMI Corporation"),
-                       DMI_MATCH(DMI_BOARD_NAME, "Aptio CRB"),
-                       /* Above strings are too generic, also match on BIOS version */
-                       DMI_MATCH(DMI_BIOS_VERSION, "ZY-8-BI-PX4S70VTR400-X423B-005-D"),
-               },
-       },
        {
                /* GP-electronic T701 */
                .driver_data = (void *)&gp_electronic_t701_data,