OSDN Git Service

brcmfmac: Avoid GFP_ATOMIC when GFP_KERNEL is enough
authorChristophe JAILLET <christophe.jaillet@wanadoo.fr>
Mon, 19 Apr 2021 19:35:17 +0000 (21:35 +0200)
committerKalle Valo <kvalo@codeaurora.org>
Thu, 22 Apr 2021 14:41:10 +0000 (17:41 +0300)
A workqueue is not atomic, so constraints can be relaxed here.
GFP_KERNEL can be used instead of GFP_ATOMIC.

Signed-off-by: Christophe JAILLET <christophe.jaillet@wanadoo.fr>
Acked-by: Arend van Spriel <arend.vanspriel@broadcom.com>
Signed-off-by: Kalle Valo <kvalo@codeaurora.org>
Link: https://lore.kernel.org/r/b6e619415db4ee5de95389280d7195bb56e45f77.1618860716.git.christophe.jaillet@wanadoo.fr
drivers/net/wireless/broadcom/brcm80211/brcmfmac/core.c

index ea78fe5..838b09b 100644 (file)
@@ -151,7 +151,7 @@ static void _brcmf_set_multicast_list(struct work_struct *work)
        /* Send down the multicast list first. */
        cnt = netdev_mc_count(ndev);
        buflen = sizeof(cnt) + (cnt * ETH_ALEN);
-       buf = kmalloc(buflen, GFP_ATOMIC);
+       buf = kmalloc(buflen, GFP_KERNEL);
        if (!buf)
                return;
        bufp = buf;