OSDN Git Service

Input: omap-keypad - set tasklet data earlier
authorDan Carpenter <dan.carpenter@oracle.com>
Thu, 7 Jan 2016 17:55:14 +0000 (09:55 -0800)
committerDmitry Torokhov <dmitry.torokhov@gmail.com>
Thu, 7 Jan 2016 17:57:21 +0000 (09:57 -0800)
It feels like we should set the tasklet data before enabling it.

Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
Signed-off-by: Dmitry Torokhov <dmitry.torokhov@gmail.com>
drivers/input/keyboard/omap-keypad.c

index 7502e46..75ad666 100644 (file)
@@ -292,8 +292,8 @@ static int omap_kp_probe(struct platform_device *pdev)
        setup_timer(&omap_kp->timer, omap_kp_timer, (unsigned long)omap_kp);
 
        /* get the irq and init timer*/
-       tasklet_enable(&kp_tasklet);
        kp_tasklet.data = (unsigned long) omap_kp;
+       tasklet_enable(&kp_tasklet);
 
        ret = device_create_file(&pdev->dev, &dev_attr_enable);
        if (ret < 0)