OSDN Git Service

bt-l2cap: fix if statement with empty body, spotted by clang
authorBlue Swirl <blauwirbel@gmail.com>
Thu, 22 Apr 2010 01:41:24 +0000 (03:41 +0200)
committerAndrzej Zaborowski <balrog@zabor.org>
Thu, 22 Apr 2010 01:41:24 +0000 (03:41 +0200)
Fix clang error:
  CC    bt-l2cap.o
/src/qemu/hw/bt-l2cap.c:1000:41: error: if statement has empty body
[-Wempty-body]
            /* TODO: Signal an error? */;

This means that l2cap_sframe_in() may now get called.

Signed-off-by: Blue Swirl <blauwirbel@gmail.com>
Signed-off-by: Andrew Zaborowski <balrogg@gmail.com>
hw/bt-l2cap.c

index 70d731e..7e2f668 100644 (file)
@@ -996,10 +996,10 @@ static void l2cap_iframe_in(struct l2cap_chan_s *ch, uint16_t cid,
         l2cap_rexmit_enable(ch, !(hdr->data[0] >> 7));
 
     if (hdr->data[0] & 1) {
-        if (len != 4)
-            /* TODO: Signal an error? */;
+        if (len != 4) {
+            /* TODO: Signal an error? */
             return;
-
+        }
         return l2cap_sframe_in(ch, le16_to_cpup((void *) hdr->data));
     }