OSDN Git Service

uio: msm_sharedmem: add guard page around shared memory
authorSahitya Tummala <stummala@codeaurora.org>
Thu, 5 Oct 2017 09:09:40 +0000 (14:39 +0530)
committerGerrit - the friendly Code Review server <code-review@localhost>
Thu, 16 Aug 2018 15:00:12 +0000 (08:00 -0700)
If guard_memory dtsi property is set, then the shared memory
region will be guarded by SZ_4K at the start and at the end.
This is needed to overcome the XPU limitation on few MSM HW,
so as to make this memory not contiguous with other allocations
that may possibly happen from other clients in the system.

Change-Id: I57637619cea8fe7f0f7254624e07177ea4a4fce0
Signed-off-by: Sahitya Tummala <stummala@codeaurora.org>
Documentation/devicetree/bindings/uio/msm_sharedmem.txt
drivers/uio/msm_sharedmem/msm_sharedmem.c

index 749c6e8..4c89846 100644 (file)
@@ -9,10 +9,18 @@ Required properties:
 - reg-names : Indicates various client-names.
 - qcom,client-id : The client id for the QMI clients.
 
+Optional properties:
+- qcom,guard-memory:   If this dtsi property is set, then the shared memory
+                       region will be guarded by SZ_4K at the start and at the end.
+                       This is needed to overcome the XPU limitation on few MSM HW,
+                       so as to make this memory not contiguous with other allocations
+                       that may possibly happen from other clients.
+
 Example:
        qcom,msm_sharedmem@0dc80000 {
                compatible = "qcom,sharedmem-uio";
                reg = <0x0dc80000 0x00180000>,
                reg-names = "rmtfs";
                qcom,client-id = <0x00000001>;
+               qcom,guard-memory;
        };
index 6336560..a929467 100644 (file)
@@ -127,10 +127,12 @@ static int msm_sharedmem_probe(struct platform_device *pdev)
        struct resource *clnt_res = NULL;
        u32 client_id = ((u32)~0U);
        u32 shared_mem_size = 0;
+       u32 shared_mem_tot_sz = 0;
        void *shared_mem = NULL;
        phys_addr_t shared_mem_pyhsical = 0;
        bool is_addr_dynamic = false;
        struct sharemem_qmi_entry qmi_entry;
+       bool guard_memory = false;
 
        /* Get the addresses from platform-data */
        if (!pdev->dev.of_node) {
@@ -165,13 +167,30 @@ static int msm_sharedmem_probe(struct platform_device *pdev)
 
        if (shared_mem_pyhsical == 0) {
                is_addr_dynamic = true;
-               shared_mem = dma_alloc_coherent(&pdev->dev, shared_mem_size,
+
+               /*
+                * If guard_memory is set, then the shared memory region
+                * will be guarded by SZ_4K at the start and at the end.
+                * This is needed to overcome the XPU limitation on few
+                * MSM HW, so as to make this memory not contiguous with
+                * other allocations that may possibly happen from other
+                * clients in the system.
+                */
+               guard_memory = of_property_read_bool(pdev->dev.of_node,
+                               "qcom,guard-memory");
+
+               shared_mem_tot_sz = guard_memory ? shared_mem_size + SZ_8K :
+                                       shared_mem_size;
+
+               shared_mem = dma_alloc_coherent(&pdev->dev, shared_mem_tot_sz,
                                        &shared_mem_pyhsical, GFP_KERNEL);
                if (shared_mem == NULL) {
                        pr_err("Shared mem alloc client=%s, size=%u\n",
                                clnt_res->name, shared_mem_size);
                        return -ENOMEM;
                }
+               if (guard_memory)
+                       shared_mem_pyhsical += SZ_4K;
        }
 
        /* Set up the permissions for the shared ram that was allocated. */