OSDN Git Service

target/arm/helper: zcr: Add build bug next to value range assumption
authorAndrew Jones <drjones@redhat.com>
Fri, 2 Aug 2019 12:25:30 +0000 (14:25 +0200)
committerPeter Maydell <peter.maydell@linaro.org>
Fri, 16 Aug 2019 13:02:51 +0000 (14:02 +0100)
The current implementation of ZCR_ELx matches the architecture, only
implementing the lower four bits, with the rest RAZ/WI. This puts
a strict limit on ARM_MAX_VQ of 16. Make sure we don't let ARM_MAX_VQ
grow without a corresponding update here.

Suggested-by: Dave Martin <Dave.Martin@arm.com>
Signed-off-by: Andrew Jones <drjones@redhat.com>
Reviewed-by: Richard Henderson <richard.henderson@linaro.org>
Reviewed-by: Eric Auger <eric.auger@redhat.com>
Signed-off-by: Peter Maydell <peter.maydell@linaro.org>
target/arm/helper.c

index 24806c1..2fd504e 100644 (file)
@@ -5300,6 +5300,7 @@ static void zcr_write(CPUARMState *env, const ARMCPRegInfo *ri,
     int new_len;
 
     /* Bits other than [3:0] are RAZ/WI.  */
+    QEMU_BUILD_BUG_ON(ARM_MAX_VQ > 16);
     raw_write(env, ri, value & 0xf);
 
     /*