OSDN Git Service

drm/amdgpu: use memcpy_toio for VCE firmware upload
authorChristian König <christian.koenig@amd.com>
Tue, 23 Aug 2016 09:18:59 +0000 (11:18 +0200)
committerAlex Deucher <alexander.deucher@amd.com>
Wed, 24 Aug 2016 20:25:07 +0000 (16:25 -0400)
Try to be clean here, even when it's a noop on x86.

Signed-off-by: Christian König <christian.koenig@amd.com>
Reviewed-by: Alex Deucher <alexander.deucher@amd.com>
Signed-off-by: Alex Deucher <alexander.deucher@amd.com>
drivers/gpu/drm/amd/amdgpu/amdgpu_vce.c

index 05865ce..da52af2 100644 (file)
@@ -282,8 +282,8 @@ int amdgpu_vce_resume(struct amdgpu_device *adev)
 
        hdr = (const struct common_firmware_header *)adev->vce.fw->data;
        offset = le32_to_cpu(hdr->ucode_array_offset_bytes);
-       memcpy(cpu_addr, (adev->vce.fw->data) + offset,
-               (adev->vce.fw->size) - offset);
+       memcpy_toio(cpu_addr, adev->vce.fw->data + offset,
+                   adev->vce.fw->size - offset);
 
        amdgpu_bo_kunmap(adev->vce.vcpu_bo);