OSDN Git Service

drm/lima: Reduce number of PTR_ERR() calls
authorKrzysztof Kozlowski <krzk@kernel.org>
Fri, 21 Jun 2019 16:21:16 +0000 (18:21 +0200)
committerQiang Yu <yuq825@gmail.com>
Sun, 23 Jun 2019 03:23:18 +0000 (11:23 +0800)
Store the PTR_ERR() result in local variable in clock init error path.
This makes the code consistent with similar section in regulator init
code.

Signed-off-by: Krzysztof Kozlowski <krzk@kernel.org>
Signed-off-by: Qiang Yu <yuq825@gmail.com>
Link: https://patchwork.freedesktop.org/patch/msgid/20190621162117.22533-3-krzk@kernel.org
drivers/gpu/drm/lima/lima_device.c

index bb2eaa4..9a6cd87 100644 (file)
@@ -83,14 +83,16 @@ static int lima_clk_init(struct lima_device *dev)
 
        dev->clk_bus = devm_clk_get(dev->dev, "bus");
        if (IS_ERR(dev->clk_bus)) {
-               dev_err(dev->dev, "get bus clk failed %ld\n", PTR_ERR(dev->clk_bus));
-               return PTR_ERR(dev->clk_bus);
+               err = PTR_ERR(dev->clk_bus);
+               dev_err(dev->dev, "get bus clk failed %d\n", err);
+               return err;
        }
 
        dev->clk_gpu = devm_clk_get(dev->dev, "core");
        if (IS_ERR(dev->clk_gpu)) {
-               dev_err(dev->dev, "get core clk failed %ld\n", PTR_ERR(dev->clk_gpu));
-               return PTR_ERR(dev->clk_gpu);
+               err = PTR_ERR(dev->clk_gpu);
+               dev_err(dev->dev, "get core clk failed %d\n", err);
+               return err;
        }
 
        err = clk_prepare_enable(dev->clk_bus);