OSDN Git Service

media: wl128x: Fix an error code in fm_download_firmware()
authorDan Carpenter <dan.carpenter@oracle.com>
Wed, 6 Mar 2019 07:27:43 +0000 (02:27 -0500)
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Wed, 29 Jan 2020 09:21:41 +0000 (10:21 +0100)
[ Upstream commit ef4bb63dc1f7213c08e13f6943c69cd27f69e4a3 ]

We forgot to set "ret" on this error path.

Fixes: e8454ff7b9a4 ("[media] drivers:media:radio: wl128x: FM Driver Common sources")

Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
Signed-off-by: Hans Verkuil <hverkuil-cisco@xs4all.nl>
Signed-off-by: Mauro Carvalho Chehab <mchehab+samsung@kernel.org>
Signed-off-by: Sasha Levin <sashal@kernel.org>
drivers/media/radio/wl128x/fmdrv_common.c

index 51639a3..0cee10c 100644 (file)
@@ -1278,8 +1278,9 @@ static int fm_download_firmware(struct fmdev *fmdev, const u8 *fw_name)
 
                switch (action->type) {
                case ACTION_SEND_COMMAND:       /* Send */
-                       if (fmc_send_cmd(fmdev, 0, 0, action->data,
-                                               action->size, NULL, NULL))
+                       ret = fmc_send_cmd(fmdev, 0, 0, action->data,
+                                          action->size, NULL, NULL);
+                       if (ret)
                                goto rel_fw;
 
                        cmd_cnt++;