OSDN Git Service

[media] rc-main: store_filter: pass errors to userland
authorJames Hogan <james.hogan@imgtec.com>
Mon, 10 Feb 2014 21:31:56 +0000 (18:31 -0300)
committerMauro Carvalho Chehab <m.chehab@samsung.com>
Tue, 11 Mar 2014 15:13:23 +0000 (12:13 -0300)
Propagate errors returned by drivers from the s_filter callback back to
userland when updating scancode filters. This allows userland to see
when the filter couldn't be updated, usually because it's not a valid
filter for the hardware.

Previously the filter was being updated conditionally on success of
s_filter, but the write always reported success back to userland.

Reported-by: Antti Seppälä <a.seppala@gmail.com>
Signed-off-by: James Hogan <james.hogan@imgtec.com>
Signed-off-by: Mauro Carvalho Chehab <m.chehab@samsung.com>
drivers/media/rc/rc-main.c

index 2ec60f8..6448128 100644 (file)
@@ -1090,7 +1090,7 @@ static ssize_t store_filter(struct device *device,
 
 unlock:
        mutex_unlock(&dev->lock);
-       return count;
+       return (ret < 0) ? ret : count;
 }
 
 static void rc_dev_release(struct device *device)