OSDN Git Service

ACPI: pfr_telemetry: Fix info leak in pfrt_log_ioctl()
authorDan Carpenter <dan.carpenter@oracle.com>
Fri, 7 Jan 2022 07:34:07 +0000 (10:34 +0300)
committerRafael J. Wysocki <rafael.j.wysocki@intel.com>
Mon, 10 Jan 2022 15:36:45 +0000 (16:36 +0100)
The "data_info" struct is copied to the user.  It has a 4 byte struct
hole after the last struct member so we need to memset that to avoid
copying uninitialized stack data to the user.

Fixes: b0013e037a8b ("ACPI: Introduce Platform Firmware Runtime Telemetry driver")
Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
Signed-off-by: Rafael J. Wysocki <rafael.j.wysocki@intel.com>
drivers/acpi/pfr_telemetry.c

index da50dd8..9abf350 100644 (file)
@@ -83,6 +83,7 @@ static int get_pfrt_log_data_info(struct pfrt_log_data_info *data_info,
        union acpi_object *out_obj, in_obj, in_buf;
        int ret = -EBUSY;
 
+       memset(data_info, 0, sizeof(*data_info));
        memset(&in_obj, 0, sizeof(in_obj));
        memset(&in_buf, 0, sizeof(in_buf));
        in_obj.type = ACPI_TYPE_PACKAGE;