OSDN Git Service

ARM: smp: Add initialization of CNTVOFF
authorMylène Josserand <mylene.josserand@bootlin.com>
Fri, 4 May 2018 19:05:39 +0000 (21:05 +0200)
committerMaxime Ripard <maxime.ripard@bootlin.com>
Tue, 8 May 2018 12:50:42 +0000 (14:50 +0200)
The CNTVOFF register from arch timer is uninitialized.
It should be done by the bootloader but it is currently not the case,
even for boot CPU because this SoC is booting in secure mode.
It leads to an random offset value meaning that each CPU will have a
different time, which isn't working very well.

Add assembly code used for boot CPU and secondary CPU cores to make
sure that the CNTVOFF register is initialized. Because this code can
be used by different platforms, add this assembly file in ARM's common
folder.

Signed-off-by: Mylène Josserand <mylene.josserand@bootlin.com>
Reviewed-by: Geert Uytterhoeven <geert+renesas@glider.be>
Tested-by: Geert Uytterhoeven <geert+renesas@glider.be>
Reviewed-by: Marc Zyngier <marc.zyngier@arm.com>
Signed-off-by: Maxime Ripard <maxime.ripard@bootlin.com>
arch/arm/common/Makefile
arch/arm/common/secure_cntvoff.S [new file with mode: 0644]
arch/arm/include/asm/secure_cntvoff.h [new file with mode: 0644]

index 70b4a14..1e9f7af 100644 (file)
@@ -10,6 +10,7 @@ obj-$(CONFIG_DMABOUNCE)               += dmabounce.o
 obj-$(CONFIG_SHARP_LOCOMO)     += locomo.o
 obj-$(CONFIG_SHARP_PARAM)      += sharpsl_param.o
 obj-$(CONFIG_SHARP_SCOOP)      += scoop.o
+obj-$(CONFIG_SMP)              += secure_cntvoff.o
 obj-$(CONFIG_PCI_HOST_ITE8152)  += it8152.o
 obj-$(CONFIG_MCPM)             += mcpm_head.o mcpm_entry.o mcpm_platsmp.o vlock.o
 CFLAGS_REMOVE_mcpm_entry.o     = -pg
diff --git a/arch/arm/common/secure_cntvoff.S b/arch/arm/common/secure_cntvoff.S
new file mode 100644 (file)
index 0000000..53fc7bd
--- /dev/null
@@ -0,0 +1,32 @@
+/* SPDX-License-Identifier: GPL-2.0 */
+/*
+ * Copyright (C) 2014 Renesas Electronics Corporation
+ *
+ * Initialization of CNTVOFF register from secure mode
+ *
+ */
+
+#include <linux/linkage.h>
+#include <asm/assembler.h>
+
+ENTRY(secure_cntvoff_init)
+       .arch   armv7-a
+       /*
+        * CNTVOFF has to be initialized either from non-secure Hypervisor
+        * mode or secure Monitor mode with SCR.NS==1. If TrustZone is enabled
+        * then it should be handled by the secure code. The CPU must implement
+        * the virtualization extensions.
+        */
+       cps     #MON_MODE
+       mrc     p15, 0, r1, c1, c1, 0           /* Get Secure Config */
+       orr     r0, r1, #1
+       mcr     p15, 0, r0, c1, c1, 0           /* Set Non Secure bit */
+       isb
+       mov     r0, #0
+       mcrr    p15, 4, r0, r0, c14             /* CNTVOFF = 0 */
+       isb
+       mcr     p15, 0, r1, c1, c1, 0           /* Set Secure bit */
+       isb
+       cps     #SVC_MODE
+       ret     lr
+ENDPROC(secure_cntvoff_init)
diff --git a/arch/arm/include/asm/secure_cntvoff.h b/arch/arm/include/asm/secure_cntvoff.h
new file mode 100644 (file)
index 0000000..1f93aee
--- /dev/null
@@ -0,0 +1,8 @@
+/* SPDX-License-Identifier: GPL-2.0 */
+
+#ifndef __ASMARM_ARCH_CNTVOFF_H
+#define __ASMARM_ARCH_CNTVOFF_H
+
+extern void secure_cntvoff_init(void);
+
+#endif