staging: comedi: usbduxfast: remove unnecessary semaphore down/up

The semaphore down/up in usbduxfast_attach_common() is not necessary.
This function is only called as part of the (*auto_attach) and does
not talk to the USB device.

Signed-off-by: H Hartley Sweeten <hsweeten@visionengravers.com>
Reviewed-by: Ian Abbott <abbotti@mev.co.uk>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>

diff --git a/drivers/staging/comedi/drivers/usbduxfast.c b/drivers/staging/comedi/drivers/usbduxfast.c
index 9e846b4..149b558 100644 (file)
--- a/drivers/staging/comedi/drivers/usbduxfast.c
+++ b/drivers/staging/comedi/drivers/usbduxfast.c
@@ -842,17 +842,12 @@ static int usbduxfast_ai_insn_read(struct comedi_device *dev,
 
 static int usbduxfast_attach_common(struct comedi_device *dev)
 {
-       struct usbduxfast_private *devpriv = dev->private;
        struct comedi_subdevice *s;
        int ret;
 
-       down(&devpriv->sem);
-
        ret = comedi_alloc_subdevices(dev, 1);
-       if (ret) {
-               up(&devpriv->sem);
+       if (ret)
                return ret;
-       }
 
        /* Analog Input subdevice */
        s = &dev->subdevices[0];
@@ -868,8 +863,6 @@ static int usbduxfast_attach_common(struct comedi_device *dev)
        s->maxdata      = 0x1000;       /* 12-bit + 1 overflow bit */
        s->range_table  = &range_usbduxfast_ai_range;
 
-       up(&devpriv->sem);
-
        return 0;
 }