OSDN Git Service
(root)
/
tomoyo
/
tomoyo-test1.git
/ commitdiff
commit
grep
author
committer
pickaxe
?
search:
re
summary
|
shortlog
|
log
|
commit
| commitdiff |
tree
raw
|
patch
| inline |
side by side
(parent:
70f13ff
)
[media] si2157: simplify si2157_cmd_execute() error path
author
Antti Palosaari
<crope@iki.fi>
Sat, 6 Dec 2014 17:04:05 +0000
(14:04 -0300)
committer
Mauro Carvalho Chehab
<mchehab@osg.samsung.com>
Thu, 29 Jan 2015 20:47:45 +0000
(18:47 -0200)
Remove if () from firmware command error path as there should not be
any error prone conditional logic there. Use goto labels instead.
Signed-off-by: Antti Palosaari <crope@iki.fi>
Signed-off-by: Mauro Carvalho Chehab <mchehab@osg.samsung.com>
drivers/media/tuners/si2157.c
patch
|
blob
|
history
diff --git
a/drivers/media/tuners/si2157.c
b/drivers/media/tuners/si2157.c
index
14d2f73
..
f7c3867
100644
(file)
--- a/
drivers/media/tuners/si2157.c
+++ b/
drivers/media/tuners/si2157.c
@@
-65,15
+65,11
@@
static int si2157_cmd_execute(struct si2157_dev *dev, struct si2157_cmd *cmd)
}
}
- ret = 0;
+ mutex_unlock(&dev->i2c_mutex);
+ return 0;
err_mutex_unlock:
mutex_unlock(&dev->i2c_mutex);
- if (ret)
- goto err;
-
- return 0;
-err:
dev_dbg(&dev->client->dev, "failed=%d\n", ret);
return ret;
}