OSDN Git Service

net/mlx4: make the array states static const, makes object smaller
authorColin Ian King <colin.king@canonical.com>
Sun, 1 Aug 2021 15:37:42 +0000 (16:37 +0100)
committerJakub Kicinski <kuba@kernel.org>
Mon, 2 Aug 2021 22:02:13 +0000 (15:02 -0700)
Don't populate the array states on the stack but instead it
static const. Makes the object code smaller by 79 bytes.

Before:
   text   data   bss    dec    hex filename
  21309   8304   192  29805   746d drivers/net/ethernet/mellanox/mlx4/qp.o

After:
   text   data   bss    dec    hex filename
  21166   8368   192  29726   741e drivers/net/ethernet/mellanox/mlx4/qp.o

(gcc version 10.2.0)

Signed-off-by: Colin Ian King <colin.king@canonical.com>
Reviewed-by: Leon Romanovsky <leonro@nvidia.com>
Reviewed-by: Tariq Toukan <tariqt@nvidia.com>
Link: https://lore.kernel.org/r/20210801153742.147304-1-colin.king@canonical.com
Signed-off-by: Jakub Kicinski <kuba@kernel.org>
drivers/net/ethernet/mellanox/mlx4/qp.c

index 427e7a3..2584bc0 100644 (file)
@@ -917,7 +917,7 @@ int mlx4_qp_to_ready(struct mlx4_dev *dev, struct mlx4_mtt *mtt,
 {
        int err;
        int i;
-       enum mlx4_qp_state states[] = {
+       static const enum mlx4_qp_state states[] = {
                MLX4_QP_STATE_RST,
                MLX4_QP_STATE_INIT,
                MLX4_QP_STATE_RTR,