OSDN Git Service

video/exynos: don't use [delayed_]work_pending()
authorTejun Heo <tj@kernel.org>
Sat, 22 Dec 2012 01:57:13 +0000 (17:57 -0800)
committerTejun Heo <tj@kernel.org>
Fri, 28 Dec 2012 21:40:16 +0000 (13:40 -0800)
There's no need to test whether a (delayed) work item in pending
before queueing, flushing or cancelling it.  Most uses are unnecessary
and quite a few of them are buggy.

Remove unnecessary pending tests from exynos_dp_core.  Only compile
tested.

Signed-off-by: Tejun Heo <tj@kernel.org>
Acked-by: Kukjin Kim <kgene.kim@samsung.com>
Acked-by: Jingoo Han <jg1.han@samsung.com>
drivers/video/exynos/exynos_dp_core.c

index 28fd686..3002a6a 100644 (file)
@@ -1121,8 +1121,7 @@ static int __devexit exynos_dp_remove(struct platform_device *pdev)
 
        disable_irq(dp->irq);
 
-       if (work_pending(&dp->hotplug_work))
-               flush_work(&dp->hotplug_work);
+       flush_work(&dp->hotplug_work);
 
        if (pdev->dev.of_node) {
                if (dp->phy_addr)
@@ -1144,8 +1143,7 @@ static int exynos_dp_suspend(struct device *dev)
        struct exynos_dp_platdata *pdata = dev->platform_data;
        struct exynos_dp_device *dp = dev_get_drvdata(dev);
 
-       if (work_pending(&dp->hotplug_work))
-               flush_work(&dp->hotplug_work);
+       flush_work(&dp->hotplug_work);
 
        if (dev->of_node) {
                if (dp->phy_addr)