OSDN Git Service

wifi: mt76: mt7915: call mt7915_mcu_set_thermal_throttling() only after init_work
authorHoward Hsu <howard-yh.hsu@mediatek.com>
Wed, 14 Dec 2022 02:28:06 +0000 (10:28 +0800)
committerFelix Fietkau <nbd@nbd.name>
Fri, 3 Feb 2023 13:47:15 +0000 (14:47 +0100)
Enable thermal management by default shall not be executed during mcu
init. This causes thermal configuration being reset to the firmware
default settings.

Fixes: 0063b86c9120 ("mt76: mt7915e: Enable thermal management by default")
Reviewed-by: Ryder Lee <ryder.lee@mediatek.com>
Signed-off-by: Howard Hsu <howard-yh.hsu@mediatek.com>
Signed-off-by: Felix Fietkau <nbd@nbd.name>
drivers/net/wireless/mediatek/mt76/mt7915/init.c
drivers/net/wireless/mediatek/mt76/mt7915/main.c

index 571c948..11407e1 100644 (file)
@@ -201,8 +201,7 @@ static int mt7915_thermal_init(struct mt7915_phy *phy)
        phy->throttle_temp[0] = 110;
        phy->throttle_temp[1] = 120;
 
-       return mt7915_mcu_set_thermal_throttling(phy,
-                                                MT7915_THERMAL_THROTTLE_MAX);
+       return 0;
 }
 
 static void mt7915_led_set_config(struct led_classdev *led_cdev,
index 0511d6a..98af032 100644 (file)
@@ -57,6 +57,12 @@ int mt7915_run(struct ieee80211_hw *hw)
                mt7915_mac_enable_nf(dev, phy->mt76->band_idx);
        }
 
+       ret = mt7915_mcu_set_thermal_throttling(phy,
+                                               MT7915_THERMAL_THROTTLE_MAX);
+
+       if (ret)
+               goto out;
+
        ret = mt76_connac_mcu_set_rts_thresh(&dev->mt76, 0x92b,
                                             phy->mt76->band_idx);
        if (ret)