OSDN Git Service

osmesa: mklib requires arguments before objects
authorChristopher James Halse Rogers <christopher.halse.rogers@canonical.com>
Mon, 24 Jan 2011 04:22:47 +0000 (20:22 -0800)
committerBrian Paul <brianp@vmware.com>
Mon, 24 Jan 2011 14:53:24 +0000 (07:53 -0700)
Fixes the build when selecting driver=osmesa and building static libraries.
Otherwise, mklib tries to add the â€˜-ltalloc’ object to the archive, which
obviously fails.

Clients which statically link to osmesa will need to link to libtalloc also,
as specified in the Libs.private of osmesa.pc.

Fixes: https://bugs.freedesktop.org/show_bug.cgi?id=33360

NOTE: This is a candidate for the 7.10 branch.

Signed-off-by: Christopher James Halse Rogers <christopher.halse.rogers@canonical.com>
Signed-off-by: Brian Paul <brianp@vmware.com>
src/mesa/drivers/osmesa/Makefile

index 50dd452..d65128c 100644 (file)
@@ -40,7 +40,7 @@ $(TOP)/$(LIB_DIR)/$(OSMESA_LIB_NAME): $(OBJECTS) $(CORE_MESA)
                -major $(MESA_MAJOR) -minor $(MESA_MINOR) -patch $(MESA_TINY) \
                -install $(TOP)/$(LIB_DIR) -cplusplus $(MKLIB_OPTIONS) \
                -id $(INSTALL_LIB_DIR)/lib$(OSMESA_LIB).$(MESA_MAJOR).dylib \
-               $(OSMESA_LIB_DEPS) $(OBJECTS) $(CORE_MESA) $(TALLOC_LIBS)
+               $(OSMESA_LIB_DEPS) $(TALLOC_LIBS) $(OBJECTS) $(CORE_MESA)