OSDN Git Service

mei: bus: don't enable events implicitly in device enable
authorTomas Winkler <tomas.winkler@intel.com>
Thu, 23 Jul 2015 12:08:37 +0000 (15:08 +0300)
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Tue, 4 Aug 2015 00:20:26 +0000 (17:20 -0700)
Do not enable events implicitly in mei_cl_enable_device, it should be
done explicitly using mei_cl_register_event_cb so the events
are enabled only when needed.
The NFC drivers has been already using it that way so no need for
further changes just remove the code from mei_cl_enable_device.

Signed-off-by: Tomas Winkler <tomas.winkler@intel.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
drivers/misc/mei/bus.c

index bec213b..257e200 100644 (file)
@@ -332,9 +332,6 @@ int mei_cl_enable_device(struct mei_cl_device *cldev)
 
        mutex_unlock(&bus->device_lock);
 
-       if (cldev->event_cb)
-               mei_cl_read_start(cldev->cl, 0, NULL);
-
        return 0;
 }
 EXPORT_SYMBOL_GPL(mei_cl_enable_device);