OSDN Git Service

PCI: pciehp: Remove pciehp_debug uses
authorBjorn Helgaas <bhelgaas@google.com>
Wed, 8 May 2019 19:59:00 +0000 (14:59 -0500)
committerBjorn Helgaas <bhelgaas@google.com>
Thu, 9 May 2019 21:45:19 +0000 (16:45 -0500)
We're about to convert pciehp to the dyndbg mechanism, which means we can
eventually remove pciehp_debug.

Replace uses of pciehp_debug with dbg() and ctrl_dbg(), which check
pciehp_debug internally.

Link: https://lore.kernel.org/lkml/20190509141456.223614-6-helgaas@kernel.org
Signed-off-by: Bjorn Helgaas <bhelgaas@google.com>
Reviewed-by: Keith Busch <keith.busch@intel.com>
Reviewed-by: Andy Shevchenko <andy.shevchenko@gmail.com>
drivers/pci/hotplug/pciehp_hpc.c

index 6a2365c..e121f1c 100644 (file)
@@ -232,8 +232,8 @@ static bool pci_bus_check_dev(struct pci_bus *bus, int devfn)
                delay -= step;
        } while (delay > 0);
 
-       if (count > 1 && pciehp_debug)
-               printk(KERN_DEBUG "pci %04x:%02x:%02x.%d id reading try %d times with interval %d ms to get %08x\n",
+       if (count > 1)
+               dbg("pci %04x:%02x:%02x.%d id reading try %d times with interval %d ms to get %08x\n",
                        pci_domain_nr(bus), bus->number, PCI_SLOT(devfn),
                        PCI_FUNC(devfn), count, step, l);
 
@@ -822,14 +822,11 @@ static inline void dbg_ctrl(struct controller *ctrl)
        struct pci_dev *pdev = ctrl->pcie->port;
        u16 reg16;
 
-       if (!pciehp_debug)
-               return;
-
-       ctrl_info(ctrl, "Slot Capabilities      : 0x%08x\n", ctrl->slot_cap);
+       ctrl_dbg(ctrl, "Slot Capabilities      : 0x%08x\n", ctrl->slot_cap);
        pcie_capability_read_word(pdev, PCI_EXP_SLTSTA, &reg16);
-       ctrl_info(ctrl, "Slot Status            : 0x%04x\n", reg16);
+       ctrl_dbg(ctrl, "Slot Status            : 0x%04x\n", reg16);
        pcie_capability_read_word(pdev, PCI_EXP_SLTCTL, &reg16);
-       ctrl_info(ctrl, "Slot Control           : 0x%04x\n", reg16);
+       ctrl_dbg(ctrl, "Slot Control           : 0x%04x\n", reg16);
 }
 
 #define FLAG(x, y)     (((x) & (y)) ? '+' : '-')