OSDN Git Service

branch: use write_file_buf instead of write_file
authorJeff King <peff@peff.net>
Fri, 8 Jul 2016 09:16:53 +0000 (05:16 -0400)
committerJunio C Hamano <gitster@pobox.com>
Fri, 8 Jul 2016 16:47:29 +0000 (09:47 -0700)
If we already have a strbuf, then using write_file_buf is a
little nicer to read (no wondering whether "%s" will eat
your NULs), and it's more efficient (no extra formatting
step).

We don't care about the newline magic of write_file(), as we
have our own multi-line content.

Signed-off-by: Jeff King <peff@peff.net>
Signed-off-by: Junio C Hamano <gitster@pobox.com>
builtin/branch.c

index 15232c4..1d41251 100644 (file)
@@ -618,7 +618,7 @@ static int edit_branch_description(const char *branch_name)
                    "  %s\n"
                    "Lines starting with '%c' will be stripped.\n",
                    branch_name, comment_line_char);
-       write_file(git_path(edit_description), "%s", buf.buf);
+       write_file_buf(git_path(edit_description), buf.buf, buf.len);
        strbuf_reset(&buf);
        if (launch_editor(git_path(edit_description), &buf, NULL)) {
                strbuf_release(&buf);