OSDN Git Service
(root)
/
uclinux-h8
/
linux.git
/ commitdiff
commit
grep
author
committer
pickaxe
?
search:
re
summary
|
shortlog
|
log
|
commit
| commitdiff |
tree
raw
|
patch
| inline |
side by side
(parent:
3a1e341
)
ALSA: nm256: Fix error return code in snd_nm256_create()
author
Yang Yingliang
<yangyingliang@huawei.com>
Tue, 20 Jul 2021 13:52:37 +0000
(21:52 +0800)
committer
Takashi Iwai
<tiwai@suse.de>
Tue, 20 Jul 2021 14:08:21 +0000
(16:08 +0200)
If pci_request_regions() fails, it should return error
code in snd_nm256_create().
Reported-by: Hulk Robot <hulkci@huawei.com>
Signed-off-by: Yang Yingliang <yangyingliang@huawei.com>
Link:
https://lore.kernel.org/r/20210720135237.3424521-1-yangyingliang@huawei.com
Signed-off-by: Takashi Iwai <tiwai@suse.de>
sound/pci/nm256/nm256.c
patch
|
blob
|
history
diff --git
a/sound/pci/nm256/nm256.c
b/sound/pci/nm256/nm256.c
index
a54b9b2
..
c9c1785
100644
(file)
--- a/
sound/pci/nm256/nm256.c
+++ b/
sound/pci/nm256/nm256.c
@@
-1478,7
+1478,8
@@
snd_nm256_create(struct snd_card *card, struct pci_dev *pci)
chip->buffer_addr = pci_resource_start(pci, 0);
chip->cport_addr = pci_resource_start(pci, 1);
- if (pci_request_regions(pci, card->driver))
+ err = pci_request_regions(pci, card->driver);
+ if (err < 0)
return err;
/* Init the memory port info. */