OSDN Git Service

misc: pci_endpoint_test: Fix failure path return values in probe
authorKishon Vijay Abraham I <kishon@ti.com>
Wed, 11 Oct 2017 08:44:36 +0000 (14:14 +0530)
committerBjorn Helgaas <bhelgaas@google.com>
Tue, 31 Oct 2017 20:33:46 +0000 (15:33 -0500)
Return value of pci_endpoint_test_probe is not set properly in a couple of
failure cases. Fix it here.

Signed-off-by: Kishon Vijay Abraham I <kishon@ti.com>
Signed-off-by: Bjorn Helgaas <bhelgaas@google.com>
drivers/misc/pci_endpoint_test.c

index d40a34f..5e7af21 100644 (file)
@@ -542,6 +542,7 @@ static int pci_endpoint_test_probe(struct pci_dev *pdev,
 
        test->base = test->bar[test_reg_bar];
        if (!test->base) {
+               err = -ENOMEM;
                dev_err(dev, "Cannot perform PCI test without BAR%d\n",
                        test_reg_bar);
                goto err_iounmap;
@@ -551,6 +552,7 @@ static int pci_endpoint_test_probe(struct pci_dev *pdev,
 
        id = ida_simple_get(&pci_endpoint_test_ida, 0, 0, GFP_KERNEL);
        if (id < 0) {
+               err = id;
                dev_err(dev, "unable to get id\n");
                goto err_iounmap;
        }