OSDN Git Service

usb: gadget: aspeed: Remove unused "suspended" flag
authorBenjamin Herrenschmidt <benh@kernel.crashing.org>
Fri, 26 Jul 2019 05:05:36 +0000 (15:05 +1000)
committerFelipe Balbi <felipe.balbi@linux.intel.com>
Mon, 12 Aug 2019 05:54:49 +0000 (08:54 +0300)
The state bit in the hub is sufficient

Signed-off-by: Benjamin Herrenschmidt <benh@kernel.crashing.org>
Signed-off-by: Felipe Balbi <felipe.balbi@linux.intel.com>
drivers/usb/gadget/udc/aspeed-vhub/dev.c
drivers/usb/gadget/udc/aspeed-vhub/vhub.h

index 79d3cb6..4008e7a 100644 (file)
@@ -89,7 +89,6 @@ static void ast_vhub_dev_enable(struct ast_vhub_dev *d)
 
        /* Additional cleanups */
        d->wakeup_en = false;
-       d->suspended = false;
        d->enabled = true;
 }
 
@@ -110,7 +109,6 @@ static void ast_vhub_dev_disable(struct ast_vhub_dev *d)
        writel(0, d->regs + AST_VHUB_DEV_EN_CTRL);
        d->gadget.speed = USB_SPEED_UNKNOWN;
        d->enabled = false;
-       d->suspended = false;
 }
 
 static int ast_vhub_dev_feature(struct ast_vhub_dev *d,
@@ -471,7 +469,6 @@ static const struct usb_gadget_ops ast_vhub_udc_ops = {
 
 void ast_vhub_dev_suspend(struct ast_vhub_dev *d)
 {
-       d->suspended = true;
        if (d->driver && d->driver->suspend) {
                spin_unlock(&d->vhub->lock);
                d->driver->suspend(&d->gadget);
@@ -481,7 +478,6 @@ void ast_vhub_dev_suspend(struct ast_vhub_dev *d)
 
 void ast_vhub_dev_resume(struct ast_vhub_dev *d)
 {
-       d->suspended = false;
        if (d->driver && d->driver->resume) {
                spin_unlock(&d->vhub->lock);
                d->driver->resume(&d->gadget);
index 00f9226..761919e 100644 (file)
@@ -354,7 +354,6 @@ struct ast_vhub_dev {
        struct usb_gadget_driver        *driver;
        bool                            registered : 1;
        bool                            wakeup_en : 1;
-       bool                            suspended : 1;
        bool                            enabled : 1;
 
        /* Endpoint structures */