OSDN Git Service

blk-cgroup: remove the !bio->bi_blkg check in blkcg_bio_issue_check
authorChristoph Hellwig <hch@lst.de>
Sat, 27 Jun 2020 07:31:55 +0000 (09:31 +0200)
committerJens Axboe <axboe@kernel.dk>
Mon, 29 Jun 2020 15:09:08 +0000 (09:09 -0600)
This is purely a sanity check for grave programming errors.  Remove it
to simplify further work in this area.

Acked-by: Tejun Heo <tj@kernel.org>
Signed-off-by: Christoph Hellwig <hch@lst.de>
Signed-off-by: Jens Axboe <axboe@kernel.dk>
include/linux/blk-cgroup.h

index 60df972..8e86b59 100644 (file)
@@ -543,24 +543,11 @@ static inline void blkcg_bio_issue_init(struct bio *bio)
 static inline bool blkcg_bio_issue_check(struct request_queue *q,
                                         struct bio *bio)
 {
-       struct blkcg_gq *blkg;
+       struct blkcg_gq *blkg = bio->bi_blkg;
        bool throtl = false;
 
        rcu_read_lock();
-
-       if (!bio->bi_blkg) {
-               char b[BDEVNAME_SIZE];
-
-               WARN_ONCE(1,
-                         "no blkg associated for bio on block-device: %s\n",
-                         bio_devname(bio, b));
-               bio_associate_blkg(bio);
-       }
-
-       blkg = bio->bi_blkg;
-
        throtl = blk_throtl_bio(q, blkg, bio);
-
        if (!throtl) {
                struct blkg_iostat_set *bis;
                int rwd, cpu;