OSDN Git Service

selftests/bpf: remove useless bpf_trace_printk
authorAlexei Starovoitov <ast@fb.com>
Sun, 29 Oct 2017 00:17:13 +0000 (17:17 -0700)
committerDavid S. Miller <davem@davemloft.net>
Wed, 1 Nov 2017 03:06:46 +0000 (12:06 +0900)
sockmap test is using two programs that use bpf_trace_printk()
which prints into trace_pipe, but nothing is reading it.
Remove it.

Fixes: 6f6d33f3b3d0 ("bpf: selftests add sockmap tests")
Signed-off-by: Alexei Starovoitov <ast@kernel.org>
Signed-off-by: David S. Miller <davem@davemloft.net>
tools/testing/selftests/bpf/sockmap_parse_prog.c
tools/testing/selftests/bpf/sockmap_verdict_prog.c

index fae3b96..a1dec2b 100644 (file)
@@ -29,9 +29,6 @@ int bpf_prog1(struct __sk_buff *skb)
         * fields.
         */
        d[7] = 1;
-
-       bpf_printk("parse: data[0] = (%u): local_port %i remote %i\n",
-                  d[0], lport, bpf_ntohl(rport));
        return skb->len;
 }
 
index 2cd2d55..d7bea97 100644 (file)
@@ -58,8 +58,6 @@ int bpf_prog2(struct __sk_buff *skb)
        d[6] = 0xe;
        d[7] = 0xf;
 
-       bpf_printk("verdict: data[0] = redir(%u:%u)\n", map, sk);
-
        if (!map)
                return bpf_sk_redirect_map(skb, &sock_map_rx, sk, 0);
        return bpf_sk_redirect_map(skb, &sock_map_tx, sk, 0);