OSDN Git Service

staging/vboxvideo: Don't set FBINFO_MISC_ALWAYS_SETPAR
authorDaniel Vetter <daniel.vetter@ffwll.ch>
Tue, 15 Jan 2019 10:27:54 +0000 (11:27 +0100)
committerDaniel Vetter <daniel.vetter@ffwll.ch>
Tue, 15 Jan 2019 15:14:47 +0000 (16:14 +0100)
It's a debug hack flag useful to work around driver bugs. That's not a
good idea for a new driver. Especially for a new drm driver.

Aside: the fbdev support should probably be converted over to the new
generic fbdev support.

Signed-off-by: Daniel Vetter <daniel.vetter@intel.com>
Cc: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Cc: Hans de Goede <hdegoede@redhat.com>
Cc: Daniel Vetter <daniel.vetter@ffwll.ch>
Cc: Bartlomiej Zolnierkiewicz <b.zolnierkie@samsung.com>
Cc: Alexander Kapshuk <alexander.kapshuk@gmail.com>
Reviewed-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Link: https://patchwork.freedesktop.org/patch/msgid/20190115102755.16183-1-daniel.vetter@ffwll.ch
drivers/staging/vboxvideo/vbox_fb.c

index 6b7aa23..397496c 100644 (file)
@@ -95,11 +95,6 @@ int vboxfb_create(struct drm_fb_helper *helper,
 
        strcpy(info->fix.id, "vboxdrmfb");
 
-       /*
-        * The last flag forces a mode set on VT switches even if the kernel
-        * does not think it is needed.
-        */
-       info->flags = FBINFO_DEFAULT | FBINFO_MISC_ALWAYS_SETPAR;
        info->fbops = &vboxfb_ops;
 
        /*