OSDN Git Service

PCI/PM: Move power state update away from pci_power_up()
authorRafael J. Wysocki <rafael.j.wysocki@intel.com>
Tue, 5 Nov 2019 10:13:43 +0000 (11:13 +0100)
committerBjorn Helgaas <bhelgaas@google.com>
Wed, 20 Nov 2019 23:35:34 +0000 (17:35 -0600)
Move the invocation of pci_update_current_state() from pci_power_up() to
pci_pm_default_resume_early(), which is the only caller of that function.

Preparatory change, no functional impact.

Link: https://lore.kernel.org/r/37482337.udjOGdOKNb@kreacher
Signed-off-by: Rafael J. Wysocki <rafael.j.wysocki@intel.com>
Signed-off-by: Bjorn Helgaas <bhelgaas@google.com>
Reviewed-by: Mika Westerberg <mika.westerberg@linux.intel.com>
drivers/pci/pci-driver.c
drivers/pci/pci.c

index e89fd90..08d3bdb 100644 (file)
@@ -531,6 +531,7 @@ static void pci_pm_default_resume(struct pci_dev *pci_dev)
 static void pci_pm_default_resume_early(struct pci_dev *pci_dev)
 {
        pci_power_up(pci_dev);
+       pci_update_current_state(pci_dev, PCI_D0);
        pci_restore_state(pci_dev);
        pci_pme_restore(pci_dev);
 }
index ea98c77..11b4d92 100644 (file)
@@ -1148,7 +1148,6 @@ void pci_power_up(struct pci_dev *dev)
 {
        __pci_start_power_transition(dev, PCI_D0);
        pci_raw_set_power_state(dev, PCI_D0);
-       pci_update_current_state(dev, PCI_D0);
 }
 
 /**