OSDN Git Service

ASoC: wm_adsp: Use DSP ops pointers to stop watchdog in error handlers
authorCharles Keepax <ckeepax@opensource.cirrus.com>
Wed, 1 May 2019 10:13:32 +0000 (11:13 +0100)
committerMark Brown <broonie@kernel.org>
Thu, 2 May 2019 02:10:35 +0000 (11:10 +0900)
Whilst this isn't strictly necessary as the code is already DSP specific
better to use the pointers to avoid potential issues in the future if
one core ends up having multiple methods of stopping the watchdog.

Signed-off-by: Charles Keepax <ckeepax@opensource.cirrus.com>
Signed-off-by: Mark Brown <broonie@kernel.org>
sound/soc/codecs/wm_adsp.c

index a9298bf..bb10c4a 100644 (file)
@@ -4285,7 +4285,7 @@ irqreturn_t wm_adsp2_bus_error(struct wm_adsp *dsp)
 
        if (val & ADSP2_WDT_TIMEOUT_STS_MASK) {
                adsp_err(dsp, "watchdog timeout error\n");
-               wm_adsp_stop_watchdog(dsp);
+               dsp->ops->stop_watchdog(dsp);
                wm_adsp_fatal_error(dsp);
        }
 
@@ -4396,7 +4396,7 @@ irqreturn_t wm_halo_wdt_expire(int irq, void *data)
        mutex_lock(&dsp->pwr_lock);
 
        adsp_warn(dsp, "WDT Expiry Fault\n");
-       wm_halo_stop_watchdog(dsp);
+       dsp->ops->stop_watchdog(dsp);
        wm_adsp_fatal_error(dsp);
 
        mutex_unlock(&dsp->pwr_lock);