OSDN Git Service

RDMA/qedr: Fix out of bounds index check in query pkey
authorGal Pressman <galpress@amazon.com>
Mon, 7 Jan 2019 15:27:56 +0000 (17:27 +0200)
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Mon, 27 Jan 2020 13:50:12 +0000 (14:50 +0100)
[ Upstream commit dbe30dae487e1a232158c24b432d45281c2805b7 ]

The pkey table size is QEDR_ROCE_PKEY_TABLE_LEN, index should be tested
for >= QEDR_ROCE_PKEY_TABLE_LEN instead of > QEDR_ROCE_PKEY_TABLE_LEN.

Fixes: a7efd7773e31 ("qedr: Add support for PD,PKEY and CQ verbs")
Signed-off-by: Gal Pressman <galpress@amazon.com>
Acked-by: Michal Kalderon <michal.kalderon@marvell.com>
Signed-off-by: Jason Gunthorpe <jgg@mellanox.com>
Signed-off-by: Sasha Levin <sashal@kernel.org>
drivers/infiniband/hw/qedr/verbs.c

index 9167a1c..8fd8b97 100644 (file)
@@ -67,7 +67,7 @@ static inline int qedr_ib_copy_to_udata(struct ib_udata *udata, void *src,
 
 int qedr_query_pkey(struct ib_device *ibdev, u8 port, u16 index, u16 *pkey)
 {
-       if (index > QEDR_ROCE_PKEY_TABLE_LEN)
+       if (index >= QEDR_ROCE_PKEY_TABLE_LEN)
                return -EINVAL;
 
        *pkey = QEDR_ROCE_PKEY_DEFAULT;