OSDN Git Service

checkpatch.pl: add common glib defines to typelist
authorPeter Xu <peterx@redhat.com>
Wed, 25 Apr 2018 07:01:03 +0000 (15:01 +0800)
committerPaolo Bonzini <pbonzini@redhat.com>
Tue, 8 May 2018 22:13:37 +0000 (00:13 +0200)
Otherwise it can warn this:

  ERROR: space prohibited between function name and open parenthesis '('

When with things like this:

  typedef gboolean (*it_tree_iterator)(ITValue start, ITValue end);

CC: Paolo Bonzini <pbonzini@redhat.com>
CC: "Daniel P. Berrangé" <berrange@redhat.com>
CC: Vladimir Sementsov-Ogievskiy <vsementsov@virtuozzo.com>
CC: Fam Zheng <famz@redhat.com>
Signed-off-by: Peter Xu <peterx@redhat.com>
Message-Id: <20180425070103.23723-1-peterx@redhat.com>
Reviewed-by: Stefan Hajnoczi <stefanha@redhat.com>
Reviewed-by: Markus Armbruster <armbru@redhat.com>
Signed-off-by: Paolo Bonzini <pbonzini@redhat.com>
scripts/checkpatch.pl

index 5b8735d..e73b4ef 100755 (executable)
@@ -265,8 +265,36 @@ our @typeList = (
        qr{${Ident}_handler_fn},
        qr{target_(?:u)?long},
        qr{hwaddr},
+        # external libraries
        qr{xml${Ident}},
        qr{xendevicemodel_handle},
+       # Glib definitions
+       qr{gchar},
+       qr{gshort},
+       qr{glong},
+       qr{gint},
+       qr{gboolean},
+       qr{guchar},
+       qr{gushort},
+       qr{gulong},
+       qr{guint},
+       qr{gfloat},
+       qr{gdouble},
+       qr{gpointer},
+       qr{gconstpointer},
+       qr{gint8},
+       qr{guint8},
+       qr{gint16},
+       qr{guint16},
+       qr{gint32},
+       qr{guint32},
+       qr{gint64},
+       qr{guint64},
+       qr{gsize},
+       qr{gssize},
+       qr{goffset},
+       qr{gintptr},
+       qr{guintptr},
 );
 
 # This can be modified by sub possible.  Since it can be empty, be careful