ANDROID: sdcardfs: Remove uninformative prints

At best these prints do not provide useful information, and
at worst, some allow userspace to abuse the kernel log.

Signed-off-by: Daniel Rosenberg <drosen@google.com>
Bug: 36138424
Change-Id: I812c57cc6a22b37262935ab77f48f3af4c36827e

diff --git a/fs/sdcardfs/derived_perm.c b/fs/sdcardfs/derived_perm.c
index f47884b..bc7f098 100644 (file)
--- a/fs/sdcardfs/derived_perm.c
+++ b/fs/sdcardfs/derived_perm.c
@@ -440,7 +440,6 @@ int setup_obb_dentry(struct dentry *dentry, struct path *lower_path)
 
        if(!err) {
                /* the obbpath base has been found */
-               printk(KERN_INFO "sdcardfs: the sbi->obbpath is found\n");
                pathcpy(lower_path, &obbpath);
        } else {
                /* if the sbi->obbpath is not available, we can optionally

diff --git a/fs/sdcardfs/file.c b/fs/sdcardfs/file.c
index 56000a0..0f2db26 100644 (file)
--- a/fs/sdcardfs/file.c
+++ b/fs/sdcardfs/file.c
@@ -217,9 +217,6 @@ static int sdcardfs_open(struct inode *inode, struct file *file)
        }
 
        if (!check_caller_access_to_name(d_inode(parent), &dentry->d_name)) {
-               printk(KERN_INFO "%s: need to check the caller's gid in packages.list\n"
-                         "     dentry: %s, task:%s\n",
-                                                __func__, dentry->d_name.name, current->comm);
                err = -EACCES;
                goto out_err;
        }

diff --git a/fs/sdcardfs/inode.c b/fs/sdcardfs/inode.c
index 3022ccc..7ca5b8a 100644 (file)
--- a/fs/sdcardfs/inode.c
+++ b/fs/sdcardfs/inode.c
@@ -68,9 +68,6 @@ static int sdcardfs_create(struct inode *dir, struct dentry *dentry,
        struct fs_struct *copied_fs;
 
        if (!check_caller_access_to_name(dir, &dentry->d_name)) {
-               printk(KERN_INFO "%s: need to check the caller's gid in packages.list\n"
-                                                "  dentry: %s, task:%s\n",
-                                                __func__, dentry->d_name.name, current->comm);
                err = -EACCES;
                goto out_eacces;
        }
@@ -170,9 +167,6 @@ static int sdcardfs_unlink(struct inode *dir, struct dentry *dentry)
        const struct cred *saved_cred = NULL;
 
        if (!check_caller_access_to_name(dir, &dentry->d_name)) {
-               printk(KERN_INFO "%s: need to check the caller's gid in packages.list\n"
-                                                "  dentry: %s, task:%s\n",
-                                                __func__, dentry->d_name.name, current->comm);
                err = -EACCES;
                goto out_eacces;
        }
@@ -280,9 +274,6 @@ static int sdcardfs_mkdir(struct inode *dir, struct dentry *dentry, umode_t mode
        struct qstr q_data = QSTR_LITERAL("data");
 
        if (!check_caller_access_to_name(dir, &dentry->d_name)) {
-               printk(KERN_INFO "%s: need to check the caller's gid in packages.list\n"
-                                                "  dentry: %s, task:%s\n",
-                                                __func__, dentry->d_name.name, current->comm);
                err = -EACCES;
                goto out_eacces;
        }
@@ -392,9 +383,6 @@ static int sdcardfs_rmdir(struct inode *dir, struct dentry *dentry)
        const struct cred *saved_cred = NULL;
 
        if (!check_caller_access_to_name(dir, &dentry->d_name)) {
-               printk(KERN_INFO "%s: need to check the caller's gid in packages.list\n"
-                                                "  dentry: %s, task:%s\n",
-                                                __func__, dentry->d_name.name, current->comm);
                err = -EACCES;
                goto out_eacces;
        }
@@ -485,9 +473,6 @@ static int sdcardfs_rename(struct inode *old_dir, struct dentry *old_dentry,
 
        if (!check_caller_access_to_name(old_dir, &old_dentry->d_name) ||
                !check_caller_access_to_name(new_dir, &new_dentry->d_name)) {
-               printk(KERN_INFO "%s: need to check the caller's gid in packages.list\n"
-                                                "  new_dentry: %s, task:%s\n",
-                                                __func__, new_dentry->d_name.name, current->comm);
                err = -EACCES;
                goto out_eacces;
        }
@@ -755,12 +740,8 @@ static int sdcardfs_setattr(struct vfsmount *mnt, struct dentry *dentry, struct
        if (!err) {
                /* check the Android group ID */
                parent = dget_parent(dentry);
-               if (!check_caller_access_to_name(d_inode(parent), &dentry->d_name)) {
-                       printk(KERN_INFO "%s: need to check the caller's gid in packages.list\n"
-                                                        "  dentry: %s, task:%s\n",
-                                                        __func__, dentry->d_name.name, current->comm);
+               if (!check_caller_access_to_name(d_inode(parent), &dentry->d_name))
                        err = -EACCES;
-               }
                dput(parent);
        }
 
@@ -872,9 +853,6 @@ static int sdcardfs_getattr(struct vfsmount *mnt, struct dentry *dentry,
 
        parent = dget_parent(dentry);
        if (!check_caller_access_to_name(d_inode(parent), &dentry->d_name)) {
-               printk(KERN_INFO "%s: need to check the caller's gid in packages.list\n"
-                                                "  dentry: %s, task:%s\n",
-                                                __func__, dentry->d_name.name, current->comm);
                dput(parent);
                return -EACCES;
        }

diff --git a/fs/sdcardfs/lookup.c b/fs/sdcardfs/lookup.c
index 58a1d80..7d26c26 100644 (file)
--- a/fs/sdcardfs/lookup.c
+++ b/fs/sdcardfs/lookup.c
@@ -395,9 +395,6 @@ struct dentry *sdcardfs_lookup(struct inode *dir, struct dentry *dentry,
 
        if (!check_caller_access_to_name(d_inode(parent), &dentry->d_name)) {
                ret = ERR_PTR(-EACCES);
-               printk(KERN_INFO "%s: need to check the caller's gid in packages.list\n"
-                         "     dentry: %s, task:%s\n",
-                                                __func__, dentry->d_name.name, current->comm);
                goto out_err;
         }